Re: CVS commit: pkgsrc

[Aleksej Saushev <asau%inbox.ru@localhost>]

John Marino <netbsd%marino.st@localhost> writes:

> On 4/8/2013 20:29, Aleksej Saushev wrote:
>> Module Name: pkgsrc
>> Committed By:        asau
>> Date:                Mon Apr  8 18:29:42 UTC 2013
>>
>> Modified Files:
>>      pkgsrc/biology/mpqc: DESCR
>>      pkgsrc/databases/phppgadmin: DESCR
>>      pkgsrc/databases/postgresql90-datatypes: DESCR
>>      pkgsrc/databases/postgresql91-datatypes: DESCR
>>      pkgsrc/databases/postgresql92-datatypes: DESCR
>>      pkgsrc/devel/fossil: DESCR
>>      pkgsrc/editors/texmaker: DESCR
>>      pkgsrc/lang/elisp-manual: DESCR
>>      pkgsrc/lang/scala: DESCR
>>      pkgsrc/math/arpack: DESCR
>>      pkgsrc/math/eigen2: DESCR
>>      pkgsrc/math/eigen3: DESCR
>>      pkgsrc/parallel/openmpi: DESCR
>>      pkgsrc/print/tex-biblatex: DESCR
>>
>> Log Message:
>> Revert pkglint-induced nonsense.
>
> Why is this "nonsense"?
> The rules (<80 chars, <= 24 lines) are good ones, as well as
> white space fixes.

First of all, these rules are nonsensical by themselves.
If pkglint insists on these rules, pkglint is broken.

Second, the way they are applied leads to nonsensical result:
 - typographical rules are violated;
 - search keywords are replaced with nonsensical abbreviations.

> You've been on a crusade against pkglint, and it appears to me
> to be a one-man crusade.  It's high time that somebody step up
> and make a declaration here.

Yes, it is time to declare pkglint BROKEN, and discuss what people
taking it as a rule are trying to achieve.

> Even if the original commit wasn't worth bothering with, that
> goes double for REVERTING it.  Isn't there guidelines about
> reverting the commits of others?  Are you following them?

Yes. I have asked to stop this, and it didn't result in any visible effect.
Instead more damage was done, e.g. breaking lang/squeak-vm.

There're common guidelines about reviewing own commits beforehand.


-- 
BECHA...
   CKOPO CE3OH...