Re: CVS commit: pkgsrc

[John Marino <netbsd%marino.st@localhost>]

On 4/8/2013 21:25, Aleksej Saushev wrote:
> John Marino<netbsd%marino.st@localhost>  writes:
> > Why is this "nonsense"?
> > The rules (<80 chars,<= 24 lines) are good ones, as well as
> > white space fixes.
>
> First of all, these rules are nonsensical by themselves.
> If pkglint insists on these rules, pkglint is broken.

As listed above, the rules aren't bad.
You should petition pkglint to change rules.  I've seen you do it 
before, and you were shot down so obviously there's disagreement on the 
quality of the rules.  You don't get to decide unilaterally.

> Second, the way they are applied leads to nonsensical result:
>   - typographical rules are violated;
>   - search keywords are replaced with nonsensical abbreviations.
>
> > You've been on a crusade against pkglint, and it appears to me
> > to be a one-man crusade.  It's high time that somebody step up
> > and make a declaration here.
>
> Yes, it is time to declare pkglint BROKEN, and discuss what people
> taking it as a rule are trying to achieve.

That's fine.  Do that.

> > Even if the original commit wasn't worth bothering with, that
> > goes double for REVERTING it.  Isn't there guidelines about
> > reverting the commits of others?  Are you following them?
>
> Yes. I have asked to stop this, and it didn't result in any visible effect.
> Instead more damage was done, e.g. breaking lang/squeak-vm.

That is NOT what the guidelines say.
http://www.netbsd.org/developers/commit-guidelines.html

=============================================
11. Do not revert other developer's commits.
=============================================
If you do not agree with another developer's commit, do not revert it on 
your own. Contact the other developer and explain to him or her the 
issues you have with the commit in question. Ask the other developer to 
back out the changes instead of doing it yourself.

If no agreement can be reached, contact the Technical Executive 
Committee <technical-exec%NetBSD.org@localhost>, which will serve as mediation 
authority.

> There're common guidelines about reviewing own commits beforehand.

Did you contact the Technical Executive Committee?

Commit reversion is highly offensive.  That's probably the reason this 
rule is documented.