On 26.07.2016 15:40, Andreas Kusalananda Kähäri wrote: > On Tue, Jul 26, 2016 at 12:16:36AM +0200, Kamil Rytarowski wrote: >> On 25.07.2016 09:55, Andreas Kusalananda Kähäri wrote: >>> On Mon, Jul 25, 2016 at 02:07:52AM +0200, Kamil Rytarowski wrote: >>>> On 24.07.2016 20:46, Amitai Schlair wrote: >>>>> On 23 Jul 2016, at 17:12, Kamil Rytarowski wrote: >>>>> >>>>>> On 23.07.2016 22:45, Thomas Klausner wrote: >>>>>>> On Sat, Jul 23, 2016 at 06:28:26PM +0000, Kamil Rytarowski wrote: >>>>>>>> @@ -218,4 +224,6 @@ BUILDLINK_DEPMETHOD.readline= build >>>>>>>> .include "../../devel/zlib/buildlink3.mk" >>>>>>>> .include "../../security/openssl/buildlink3.mk" >>>>>>>> .include "../../mk/dlopen.buildlink3.mk" >>>>>>>> +# Required to detect X11BASE paths in dlopen(3) calls of _ctypes.so >>>>>>>> +.include "../../mk/x11.buildlink3.mk" >>>>>>>> .include "../../mk/bsd.pkg.mk" >>>>>>> >>>>>>> This breaks the build with X11_TYPE=modular: >>>>>>> >>>>>>> Do not include x11.buildlink3.mk for X11_TYPE != "native" >>>>>> >>>>>> Should be fine now. Thank you! >>>>> >>>>> This (and maybe previous as well) breaks the build on a system without >>>>> X11. Can we declare an "x11" option for lang/python27 and only apply the >>>>> intended fix when PKG_OPTIONS.x11 is enabled? > [cut] >> >> Please try this patch: >> >> http://netbsd.org/~kamil/patch-00004-python27-x11native-2.txt >> > > This works on my X-less Darwin system and the package builds, but only > if I set > > PKG_OPTIONS.python27= -x11 > > AFAIK, there is no other package that I need to explicitly choose "-x11" > for. I don't particularly like this solution. I'd rather it'd be the > opposite, like Amitai suggested above. > > > Andreas > The point is to get functional desktop from binary prebuilt packages. Perhaps this option can be disabled for Darwin if it is the default case that there is no X Window? Thank you for testing! I will commit it as it is for now and tune it for Darwin on demand.
Attachment:
signature.asc
Description: OpenPGP digital signature