Re: CVS commit: pkgsrc/math/py-Scientific-doc

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Friday, July 29, 2016, Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> On Thu, Jul 28, 2016 at 10:38:39PM +0200, Joerg Sonnenberger wrote:
> > On Tue, Jul 26, 2016 at 09:54:45AM -0700, Alistair Crooks wrote:
> > > Actually, I disagree - we need to talk about this, as the practice of
> > > copying information from the PLIST into the Makefile, having to
> > > maintain information in 2 places, and in general muddying the waters
> > > between a list of files in the package (the PLIST) and the
> > > instructions for building the whole package -- these 2 need to be kept
> > > distinct, both logically and physically.
> > >
> > > If AUTO_MKDIRS isn't working properly, let's fix it, and then make it
> > > the default, please
> >
> > Consider the typical example of
> >     ${BSD_INSTALL_PROG} foo ${DESTDIR}${PREFIX}/bin
> >
> > This will complete successfully, whether bin is a directory or not.
> > With AUTO_MKDIRS, removing the PLIST, touching it, running stage-install
> > and then print-PLIST > PLIST will have a different result compared to
> > just stage-install. As such, I consider the part about creating bin a
> > very important and explicit part of the build instructions.
>
> To put this differently: I strongly prefer a dumb PLIST that can always
> be regenerated over a semi-smart PLIST that must exist to build the
> package. The PLIST is already redundant, so the argument for removing
> essential build instructions from the Makefile doesn't cut for me.
>
> Joerg

No-one is suggesting making the PLIST "smarter" since it already contains all the information needed. Unsure why you're trying to suggest this?

These are hardly essential build instructions, since AUTO_MKDIRS being set in the PLIST will DTRT. If it doesn't, your PLIST is incorrect.

However, there is scope for the PLIST to be correct, and the package not to install correctly since the directory entries in the Makefile are stale or out of date.

Logically, AUTO_MKDIRS is the correct solution, and I cannot understand why anyone would argue against it