Re: CVS commit: pkgsrc/multimedia/mpv

[Pierre Pronchery <khorben%netbsd.org@localhost>]

                        Hi Leonardo, all,

On 31/01/2017 09:58, Leonardo Taccari wrote:
> "Pierre Pronchery" writes:
> > Module Name:    pkgsrc
> > Committed By:   khorben
> > Date:           Tue Jan 31 01:37:19 UTC 2017
> >
> > Modified Files:
> >         pkgsrc/multimedia/mpv: Makefile options.mk
> >
> > Log Message:
> > Add support for more dependencies by default
> >
> > This registers support for libXrandr and libXScrnSaver. Pulseaudio is now
> > suggested by default as well (as is the case for mplayer).
> >
> > Bump PKGREVISION.
>
> Thank you for adding missing dependencies to mpv!

You are very welcome :)

> However, can you please revert the pulseaudio part?
>
> While it can be handy for current stable NetBSD versions I think
> it's less important for NetBSD 8.0 (thanks to recent <nat> works!)
> and as a MAINTAINER I would like to avoid pulseaudio dependency by
> default for mpv.

I still believe the "pulseaudio" audio should be enabled by default, for 
the following reasons:

Consistency
===========

Across pkgsrc
-------------
Other packages, including MPlayer (the historical parent of mpv) do 
default to having support for pulseaudio enabled by default where 
available. At the moment it seems we have three versions of pkgsrc:
- default settings untouched;
- with pulseaudio support always enabled;
- without pulseaudio support when optional.

This should really be reduced to "with pulseaudio" or "without pulseaudio".

End-user experience (binary packages)
-------------------
As a direct consequence in this case, end-users have to know/guess which 
video player is going to work in which situation. For those who prefer 
mpv to mplayer (like I do) they will find that they will have to stick 
to mplayer while e.g. firefox is also running. This gives a very flaky 
experience of the platform at best.

Availability of NetBSD 8
========================

While I really look forward to running NetBSD 8 on my machines myself, 
it really does not exist yet. One has to run -current to get a preview 
of what NetBSD 8 will be like, and this is definitely not suitable for 
end users now. Even once NetBSD 8 will be released, it will take some 
time for every one to catch up (probably a good 6 months, so 3 pkgsrc 
releases).

Minimalism
==========

Some of us (including myself) appreciate pkgsrc for the sane and rather 
minimalistic defaults - probably developers in particular. This is the 
crowd which typically builds its packages themselves anyway, with 
PKG_DEFAULT_OPTIONS+=-pulseaudio in /etc/mk.conf already (yes, me too).
So while it should not matter so much here, I can understand the 
concern. Then we could say let's disable it everywhere possible too.

However...

Configurable
============

...mpv can very easily be configured to default to OSS, regardless of 
how it was compiled in the first place:
$ echo ao=oss >> ~/.config/mpv/mpv.conf

While this works fine in this case, I do recognize concerns in other 
situations with a similar problem, like support for printing in Gtk+ 2 
and 3: the extra dependencies are quite heavy and configuration is not 
possible. I really wish I didn't have to build pkgsrc from source just 
to be able to print though... :(

Conclusion
==========

I am sorry I committed this without going through you first. Feel free 
to change the package again as you see fit. I would appreciate if we 
could reach a consensus on which option should/could be always enabled 
by default, possibly per platform. Where should this information go?

Cheers & HTH,
--
khorben