Re: CVS commit: pkgsrc/multimedia/mpv

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Pierre Pronchery writes:
>                       Hi Leonardo, all,
> 

Hello Pierre!

Thanks for the analysis (I will omit to quote it in this email)!

> [...]
> 
> I am sorry I committed this without going through you first. Feel free 
> to change the package again as you see fit. I would appreciate if we 
> could reach a consensus on which option should/could be always enabled 
> by default, possibly per platform. Where should this information go?
> 
> [...]

OK, I'm now convinced that at least for multimedia/mpv it's probably
good to add "pulseaudio" as PKG_SUGGESTED_OPTIONS, I've gave a quick
look to other packages that have a pulseaudio options (this is probably
not super-exact but will hopefully give us an idea):

% ag --ignore-dir wip -G 'Makefile*|options.mk' '^PKG_(SUPPORTED|SUGGESTED)_OPTIONS.*pulseaudio' | \
   awk -F : \
   '/SUPPORTED/ { packages[$1] = 0; }' \
   '/SUGGESTED/ { packages[$1] = 1; }' \
   'END {' \
   'for (p in packages) {' \
   '   split(p, sp, "/");' \
   '   printf("%s/%s: %s\n", sp[1], sp[2], packages[p] ? "suggested" : "supported"); }; }' \
   | sort
audio/audacious-plugins: suggested
audio/cmus: supported
audio/libopenmpt: suggested
audio/musicpd: supported
audio/xmp: suggested
devel/SDL2: supported
devel/SDL: suggested
devel/gmtk: suggested
devel/xulrunner10: supported
devel/xulrunner17: supported
emulators/snes9x-gtk: supported
emulators/wine-devel: supported
lang/squeak-vm: supported
mail/thunderbird31: suggested
mail/thunderbird38: suggested
mail/thunderbird: suggested
meta-pkgs/gnome: suggested
multimedia/adobe-flash-plugin11: supported
multimedia/avidemux: suggested
multimedia/kmix: supported
multimedia/mate-media: suggested
multimedia/mplayer-share: supported
multimedia/mpv: suggested
multimedia/phonon: supported
multimedia/swfdec: suggested
multimedia/vlc20: supported
multimedia/vlc: supported
net/freerdp: supported
net/gtk-vnc: supported
security/tor-browser: suggested
sysutils/gnome-settings-daemon: supported
www/firefox24: suggested
www/firefox31: suggested
www/firefox38: suggested
www/firefox45: suggested
www/firefox: suggested
www/seamonkey: suggested
x11/kde-runtime4: supported

20 of 38 packages that have "pulseaudio" option also have it as a
PKG_SUGGESTED_OPTIONS.

Regarding a consensus, IMHO the most important consideration
should be about what users expect from the package (...and that
can be difficult to predict! :)) - consistency can help for that
though!


Thank you again!