Re: CVS commit: pkgsrc/www/firefox

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

Sorry for my late reply.

nia <nia%NetBSD.org@localhost> writes:

> On Sat, Jun 19, 2021 at 04:33:06AM +0900, Ryo ONODERA wrote:
>> Hi,
>> 
>> "Nia Alarie" <nia%netbsd.org@localhost> writes:
>> 
>> > Module Name:       pkgsrc
>> > Committed By:      nia
>> > Date:              Fri Jun 18 18:08:05 UTC 2021
>> >
>> > Modified Files:
>> >    pkgsrc/www/firefox: Makefile
>> >
>> > Log Message:
>> > firefox: Explicitly use autoconf-2.13
>> >
>> > Candidate fix for PR pkg/56261
>> 
>> Please stop to commit this incorrect change and same changes for
>> Mozilla packages.
>
> Hi Ryo,
>
>> 
>> https://mail-index.netbsd.org/pkgsrc-changes/2021/06/13/msg236827.html
>> is real cause of the problem.
>> This commit places autoconf 2.71 as ${WRKDIR}.buildlink/bin/autoconf
>> and these packages pick up this autoconf 2.71 instead of
>> ${WRKSRC}/.tools/bin/autoconf 2.13.
>> The commit for lang/llvm breaks pkgsrc's autoconf selection mechanism
>> and should be reverted.
>> 
>> Thank you.
>
> Thank you for the research.
>
> We observed this problem was present except in pbulk,
> where the build environment is clean of other versions of
> autoconf. Since we assumed the problem was environment
> pollution, I had thought explicitly specifying the correct
> excecutable name for autoconf would be a good change regardless
> of it fixing this specific problem. Can you explain why it's
> a harmful change?
>
> I would assume it would be better to use a make variable
> to find the exact autoconf executable we want, similarly
> as for other tools. The commands seem to be run without
> ALL_ENV (etc.), too.

The original pkgsrc intension is ${WRKSRC}/.tools/bin/autoconf is
synchronized with autoconfs (autoconf (2.71) or autoconf213 (2.13)).
Your hardcoded autoconf-2.13 breaks this synchronization.

Of course your direct autoconf-2.13 invocation will work too.
However it does not follow the original concept.

Thank you.

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3