Re: CVS commit: pkgsrc/mk/compiler

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Sat, Nov 06, 2021 at 10:03:32AM +0000, Nia Alarie wrote:
> Module Name:  pkgsrc
> Committed By: nia
> Date:         Sat Nov  6 10:03:32 UTC 2021
> 
> Modified Files:
>       pkgsrc/mk/compiler: clang.mk gcc.mk
> 
> Log Message:
> mk: Correct the wrappers invocation for RELRO. This should help many
> remaining packages that fail to build with RELRO that were uncaught
> by my original bulk builds due to CHECK_RELRO failing to work (sorry...)
...
> -CWRAPPERS_APPEND.ld+=        ${_RELRO_LDFLAGS}
> +CWRAPPERS_APPEND.cc+=        ${_RELRO_LDFLAGS}
> +CWRAPPERS_APPEND.cxx+=       ${_RELRO_LDFLAGS}



Any thoughts on joerg's comment that these should be prepended
rather than appended?

I have a local patch which PREPENDs, and the xentools415 broke in
a different (I think unrelated to relro) place, which suggests that
experiment matches theory.


Cheers,

Patrick