Re: CVS commit: pkgsrc/mk/compiler

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

"Nia Alarie" <nia%netbsd.org@localhost> writes:

> Module Name:  pkgsrc
> Committed By: nia
> Date:         Sat Nov  6 10:03:32 UTC 2021
>
> Modified Files:
>       pkgsrc/mk/compiler: clang.mk gcc.mk
>
> Log Message:
> mk: Correct the wrappers invocation for RELRO. This should help many
> remaining packages that fail to build with RELRO that were uncaught
> by my original bulk builds due to CHECK_RELRO failing to work (sorry...)
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.29 -r1.30 pkgsrc/mk/compiler/clang.mk
> cvs rdiff -u -r1.230 -r1.231 pkgsrc/mk/compiler/gcc.mk
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

This change breaks CC_VERION mechanism in GNU configure script
in pkgsrc/graphics/gimp, for example.

Please restrict RELRO flags for linker only.


Under NetBSD/amd64 9.99.92:
The following is expected output.
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/lto-wrapper
Target: x86_64--netbsd
Configured with: /usr/src/tools/gcc/../../external/gpl3/gcc/dist/configure --target=x86_64--netbsd --enable-long-long --enable-threads --with-bugurl=http://www.NetBSD.org/support/send-pr.html 
--with-pkgversion='NetBSD nb1 20210411' --with-system-zlib --without-isl --enable-__cxa_atexit --enable-libstdcxx-time=rt --enable-libstdcxx-threads --with-diagnostics-color=auto-if-env 
--with-tune=nocona --with-default-libstdcxx-abi=new --with-mpc-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/mpc/lib/libmpc 
--with-mpfr-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/mpfr/lib/libmpfr --with-gmp-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/gmp/lib/libgmp 
--with-mpc-include=/usr/src/external/lgpl3/mpc/dist/src --with-mpfr-include=/usr/src/external/lgpl3/mpfr/dist/src --with-gmp-include=/usr/src/external/lgpl3/gmp/lib/libgmp/arch/x86_64 --enable-tls 
--disable-multilib --disable-libstdcxx-pch --build=x86_64--netbsd --host=x86_64--netbsd --with-sysroot=/var/obj/mknative/amd64-x86_64/usr/src/destdir.amd64
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 10.3.0 (nb1 20210411)


This is problematic output with

CWRAPPERS_APPEND.cc+=        ${_RELRO_LDFLAGS}
CWRAPPERS_APPEND.cxx+=       ${_RELRO_LDFLAGS}

$ gcc -v -Wl,-zrelro -Wl,-znow
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/lto-wrapper
Target: x86_64--netbsd
Configured with: /usr/src/tools/gcc/../../external/gpl3/gcc/dist/configure --target=x86_64--netbsd --enable-long-long --enable-threads --with-bugurl=http://www.NetBSD.org/support/send-pr.html 
--with-pkgversion='NetBSD nb1 20210411' --with-system-zlib --without-isl --enable-__cxa_atexit --enable-libstdcxx-time=rt --enable-libstdcxx-threads --with-diagnostics-color=auto-if-env 
--with-tune=nocona --with-default-libstdcxx-abi=new --with-mpc-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/mpc/lib/libmpc 
--with-mpfr-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/mpfr/lib/libmpfr --with-gmp-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/gmp/lib/libgmp 
--with-mpc-include=/usr/src/external/lgpl3/mpc/dist/src --with-mpfr-include=/usr/src/external/lgpl3/mpfr/dist/src --with-gmp-include=/usr/src/external/lgpl3/gmp/lib/libgmp/arch/x86_64 --enable-tls 
--disable-multilib --disable-libstdcxx-pch --build=x86_64--netbsd --host=x86_64--netbsd --with-sysroot=/var/obj/mknative/amd64-x86_64/usr/src/destdir.amd64
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 10.3.0 (nb1 20210411)
COMPILER_PATH=/usr/libexec/
LIBRARY_PATH=/usr/lib/
COLLECT_GCC_OPTIONS='-v' '-mtune=nocona' '-march=x86-64'
 ld -plugin /usr/libexec/liblto_plugin.so -plugin-opt=/usr/libexec/lto-wrapper -plugin-opt=-fresolution=/tmp//ccVmIa9R.res -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lgcc 
-plugin-opt=-pass-through=-lc -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lgcc --eh-frame-hdr -dc -dp -e _start -dynamic-linker /usr/libexec/ld.elf_so /usr/lib/crt0.o /usr/lib/crti.o 
/usr/lib/crtbegin.o -zrelro -znow --as-needed -lgcc_s --no-as-needed -lgcc -lc --as-needed -lgcc_s --no-as-needed -lgcc /usr/lib/crtend.o /usr/lib/crtn.o
ld: /usr/lib/crt0.o: in function `___start':
(.text+0x2d9): undefined reference to `main'

The following lines are not expected and cause build failure.

ld: /usr/lib/crt0.o: in function `___start':
(.text+0x2d9): undefined reference to `main'

Thank you.

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3