Re: multimedia/vlc does not configure (x11-xcb) (blocking bug)

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Sat, 07 May 2011 11:01:30 +0900
    From:        "OBATA Akio" <obache%NetBSD.org@localhost>
    Message-ID:  <op.vu288smkcmitfu%ponkan.lins.jp@localhost>

  | Just from configure script, only xcb_glx puugin require x11-xcb.
  | How about just following (not tested) ?

That works, at least to get the build past the configure stage
(it is still compiling as I send this).

Or rather, the patch below works, which is just your patch, without
tab/space mangling which looks to have been a cut&past type problem...
(I include this just to make it easier for anyone else who wants to
test this before the patch gets committed, which I assume will happen
sometime after it is confirmed that the build completes properly).

Thanks.

kre

ps: the configure, and whatever leads up to it (and the compile, or
what I have seen of it) is very noisy - ie: lots of warnings about all
kinds of crud (lots of libtool warnings, and stuff like that) - more
than I am used to seeing in pkgsrc packages.

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/multimedia/vlc/Makefile,v
retrieving revision 1.111
diff -u -r1.111 Makefile
--- Makefile    22 Apr 2011 13:42:03 -0000      1.111
+++ Makefile    8 May 2011 02:21:27 -0000
@@ -26,7 +26,7 @@
 CONFIGURE_ARGS+=       --with-kde-solid=${PREFIX}/share/kde/apps/solid/actions
 PTHREAD_OPTS+=         require
 USE_LANGUAGES=         c99 c++
-PLIST_VARS+=           x86simd altivec v4l2 vcd cdda
+PLIST_VARS+=           x86simd altivec v4l2 vcd cdda glx
 
 .include "../../mk/bsd.prefs.mk"
 .include "options.mk"
@@ -152,6 +152,11 @@
 # libX11 should be built with xcb enabled
 BUILDLINK_API_DEPENDS.libX11+= libX11>=1.3.5
 .include "../../x11/libX11/buildlink3.mk"
+.if ${X11_TYPE} == "modular" || exists(${X11BASE}/lib/pkgconfig/xcb.pc)
+PLIST.glx=     yes
+.else
+CONFIGURE_ARGS+=       --disable-glx
+.endif
 # needs x264_encoder_delayed_frames
 BUILDLINK_API_DEPENDS.x264-devel+= x264-devel>=20100201
 .include "../../multimedia/x264-devel/buildlink3.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/multimedia/vlc/PLIST,v
retrieving revision 1.41
diff -u -r1.41 PLIST
--- PLIST       6 Apr 2011 08:14:21 -0000       1.41
+++ PLIST       8 May 2011 02:22:53 -0000
@@ -339,7 +339,7 @@
 ${PLIST.x11}lib/vlc/plugins/video_output/libsnapshot_plugin.la
 lib/vlc/plugins/video_output/libvmem_plugin.la
 lib/vlc/plugins/video_output/libvout_wrapper_plugin.la
-${PLIST.x11}lib/vlc/plugins/video_output/libxcb_glx_plugin.la
+${PLIST.glx}lib/vlc/plugins/video_output/libxcb_glx_plugin.la
 ${PLIST.x11}lib/vlc/plugins/video_output/libxcb_window_plugin.la
 ${PLIST.x11}lib/vlc/plugins/video_output/libxcb_x11_plugin.la
 ${PLIST.x11}lib/vlc/plugins/video_output/libxcb_xv_plugin.la