pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: gcc 4.8 warnings and xentools42



On Thu, Mar 27, 2014 at 01:36:01PM +0100, Martin Husemann wrote:
> On Wed, Mar 26, 2014 at 10:42:35AM +0000, Patrick Welche wrote:
> >    temp = E1000_READ_REG(hw, CRCERRS);
> >    temp = E1000_READ_REG(hw, SYMERRS);
> > ...
> > 
> > So, temp is never used, but it looks as though this is an attempt to
> > make sure the READ isn't optimised away? Safe to just get rid of the 
> > temp?
> 
> If the E1000_READ_REG properly uses bus space or a volatile pointer, the
> storing to temp is not needed.

After making 25 patches, I gave up and just switched the warning flag off...

Cheers,

Patrick


Home | Main Index | Thread Index | Old Index