Re: Inform 6 package needs updating, listed maintaner hasn't been active in a decade.

["J. Lewis Muir" <jlmuir%imca-cat.org@localhost>]

On 07/24, coypu%sdf.org@localhost wrote:
> Hi,
> 
> asking here is fine. feel free to point out any packages ytou would like
> to see updated.
> 
> I have an update to the package in a diff, can you test if this works
> for you?
> 
> You can apply it with:
> 
> cd /usr/pkgsrc/lang/inform
> patch -p0 < inform.diff
> 
> Thanks

[snip]

> Index: patches/patch-Makefile
> ===================================================================
> RCS file: patches/patch-Makefile
> diff -N patches/patch-Makefile
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ patches/patch-Makefile	24 Jul 2017 00:41:33 -0000
> @@ -0,0 +1,47 @@
> +$NetBSD$
> +
> +Allow overriding PREFIX
> +DESTDIR support
> +
> +--- Makefile.orig	2016-06-04 03:25:08.000000000 +0000
> ++++ Makefile
> +@@ -2,7 +2,7 @@ CC = gcc
> + 
> + #OPTS = -g -Wall -Wextra
> + 
> +-PREFIX = /usr/local
> ++PREFIX ?= /usr/local

Why this change to the PREFIX variable assignment?  I know from the
make(1) man page that "?=" means "assign the value to the variable if
it is not already defined," but I think that applies to just within the
Makefile, no?  By the "Allow overriding PREFIX" comment at the top of
the patch file, do you mean specifying command line arguments to make of
the form <var_name>=<value>?  So, for example:

$ make PREFIX=/opt/pkg

I think that still works with "PREFIX = /usr/local" in Makefile; the
value of PREFIX in the Makefile will be "/opt/pkg" for this invocation.
I don't think you need the "?=" variable assignment modifier for this
case.  Or is there a different use case you're targeting, or am I
missing something?

Regards,

Lewis