Re: mail/postfix: PKGREVISION in Makefile or Makefile.common?

[Roland Illig <roland.illig%gmx.de@localhost>]

Am 16.07.2019 um 17:08 schrieb Frédéric Fauberteau:
> I had a doubt because there seems to be some exceptions:
> $ find . -type f -name "Makefile.common" -exec grep -q PKGREVISION '{}'
> \; -and -print
> ./archivers/gtar/Makefile.common
> ./wip/xspd/Makefile.common
> ./wip/lapack/Makefile.common
> ./devel/libtool/Makefile.common
> ./editors/emacs/Makefile.common
> ./math/lapack/Makefile.common
> ./misc/open2300/Makefile.common
> ./net/net-snmp/Makefile.common
> ./wm/icewm/Makefile.common
> ./x11/xscreensaver/Makefile.common

These are clearly bugs. The PKGREVISION must only be defined in a
package's Makefile, and defining it somewhere else will overwrite the
definition from the Makefile with a nonsensical value. Therefore pkglint
reports an error for this situation, since at least 2008:

$ pkglint archivers/gtar -e
ERROR: archivers/gtar/Makefile.common:8: PKGREVISION only makes sense
directly in the package Makefile.

    Usually, different packages using the same Makefile.common have
    different dependencies and will be bumped at different times (e.g.
    for shlib major bumps) and thus the PKGREVISIONs must be in the
    separate Makefiles. There is no practical way of having this
    information in a commonly used Makefile.

1 error found.

Roland