Re: Excluding subdirs from $PKGSRCDIR with lintpkgsrc

[Roland Illig <roland.illig%gmx.de@localhost>]

On 17.12.2020 10:56, Ottavio Caruso wrote:
> [chroot]root@e130:~/cvs/pkgsrc/current/pkgsrc# lintpkgsrc -K
> /root/pkgsrc/packages/ -M /root/pkgsrc/distfiles/ -opr
> ...
> Bogus: PKGREVISION ${_GIT_PKGVERSION:S/.//g} (from
> /root/cvs/pkgsrc/current/pkgsrc/wip/8cc-git/Makefile)

I just released lintpkgsrc 4.96, which does not complain about
_CVS_PKGVERSION, _GIT_PKGVERSION, _HG_PKGVERSION and _SVN_PKGVERSION
anymore.  The files from the pkgsrc-wip infrastructure should not have
defined PKGREVISION in the first place, but that's an entirely different
issue.

> Bogus: ${DISTNAME:tl:S/-v//} (from
> /root/cvs/pkgsrc/current/pkgsrc/wip/pike/Makefile)

Lintpkgsrc just doesn't use the right strategy for extracting the
PKGNAME, DISTNAME, DISTFILES and PKGREVISION.

Instead of trying to parse the Makefiles itself, it should rather do so
only for the most trivial cases, falling back to running "bmake
show-vars" if it is unsure, even if this means that determining the
variables is slower.

Roland