Re: mail/offlineimap rfc6555 module dependency missing

["J. Lewis Muir" <jlmuir%imca-cat.org@localhost>]

On 08/02, Greg Troxel wrote:
> "J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:
> > I don't think the rfc6555 module is in pkgsrc, so I think one solution
> > would be to add it to pkgsrc and then to add it as a dependency of
> > mail/offlineimap.
> 
> Sure.  You should feel free to add it to pkgsrc-wip.

Well, I went to add it to wip/py-rfc6555, but it turns out it was
already there.  Unfortunately, the date of the last commit on it is Mon
Feb 14 10:36:00 2022 +0100.  Since I don't want to change someone else's
wip work, I made changes to it locally, and I've included a diff of my
changes to it below.

Then I found that py-rfc6555 needed the Python selectors2 module, so I
added that at wip/py-selectors2.

And then I needed to add the dependency on wip/py-rfc6555 to
mail/offlineimap.  The diff for that is below also.

With that, mail/offlineimap runs successfully for me on macOS Sonoma.

I'd like to request that these changes be committed to pkgsrc.

Thanks!

Lewis

==== py-rfc6555.diff ====
diff --git a/py-rfc6555/COMMIT_MSG b/py-rfc6555/COMMIT_MSG
new file mode 100644
index 0000000000..b5f73b1d37
--- /dev/null
+++ b/py-rfc6555/COMMIT_MSG
@@ -0,0 +1 @@
+net/py-rfc6555: Add
diff --git a/py-rfc6555/Makefile b/py-rfc6555/Makefile
index b8f24272df..01cc031b25 100644
--- a/py-rfc6555/Makefile
+++ b/py-rfc6555/Makefile
@@ -2,15 +2,19 @@
 
 DISTNAME=	rfc6555-0.1.0
 PKGNAME=	${PYPKGPREFIX}-${DISTNAME}
-CATEGORIES=	devel python python
-MASTER_SITES=	https://files.pythonhosted.org/packages/f6/4b/24f953c3682c134e4d0f83c7be5ede44c6c653f7d2c0b06ebb3b117f005a/
+CATEGORIES=	net python
+MASTER_SITES=	${MASTER_SITE_PYPI:=r/rfc6555/}
 
-MAINTAINER=	pickles%tilde.pink@localhost
+MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=	https://www.github.com/sethmlarson/rfc6555
 COMMENT=	Implementation of the Happy Eyeballs Algorithm described in RFC 6555
 LICENSE=	apache-2.0
 
-DEPENDS+=	${PYPKGPREFIX}-selectors2>=2.0.1:../../devel/py-selectors2
+USE_LANGUAGES=	# none
+
+PYTHON_27_ACCEPTED=	yes
+
+DEPENDS+=	${PYPKGPREFIX}-selectors2>=2.0.1:../../net/py-selectors2
 
 .include "../../lang/python/egg.mk"
 .include "../../mk/bsd.pkg.mk"
====

==== offlineimap.diff ====
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/offlineimap/Makefile,v
retrieving revision 1.41
diff -u -r1.41 Makefile
--- Makefile	23 Oct 2023 06:37:48 -0000	1.41
+++ Makefile	2 Aug 2024 20:49:27 -0000
@@ -15,6 +15,7 @@
 PYTHON_VERSIONS_ACCEPTED=	27 # not yet ported

 DEPENDS+=	${PYPKGPREFIX}-six-[0-9]*:../../lang/py-six
+DEPENDS+=	${PYPKGPREFIX}-rfc6555-[0-9]*:../../net/py-rfc6555

 INSTALLATION_DIRS=	share/examples/offlineimap

====