Re: CVS commit: src/doc

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sat, Dec 13, 2003 at 08:18:08AM +0900, Jun-ichiro itojun Hagino wrote:
> > I'm sorry, but I don't think that's sufficient.  It should not be
> > necessary to have to use cvs diff to find out what changed - because,
> > even then, that will only give me an idea of the differences at the
> > lowest level.  What the log should show is a high-level overview of
> > the changes that were made.
> 
>       tell me what is the high-level overview which is between "cvs"
>       (which is the commit message) and below.  i can't think of one.

I'd prefer it if you'd put the reason for the upgrade into the list
of changes - I mean, if there was a security problem with the software,
I think it's only right that you let everyone know, so that they can take
steps to ameliorate the situation.

How about

        upgrade to cvs 1.11.10 to fix a possible security vulnerability 
        with unauthorised directories being created in cvs root through
        the use of absolute paths

It'd be great if you could do this for all of your commit messages,
not just the documentation ones.

Thanks,
Alistair

> 
> Index: CHANGES
> ===================================================================
> RCS file: /cvsroot/src/doc/CHANGES,v
> retrieving revision 1.235
> retrieving revision 1.236
> diff -u -r1.235 -r1.236
> --- CHANGES   7 Dec 2003 22:55:12 -0000       1.235
> +++ CHANGES   10 Dec 2003 06:15:24 -0000      1.236
> @@ -1,4 +1,4 @@
> -LIST OF CHANGES FROM LAST RELEASE:                   <$Revision: 1.235 $>
> +LIST OF CHANGES FROM LAST RELEASE:                   <$Revision: 1.236 $>
>  
>  
>  [Note: This file does not mention every change made to the NetBSD source 
> tree.
> @@ -540,3 +540,4 @@
>               tokenization routines.  [lukem 20031205]
>       sh5: Switch sh5 to the in-tree toolchain, albeit somewhat hobbled.
>               [scw 20031207]
> +     cvs(1): upgrade to 1.11.10 [itojun 20031210]