Re: CVS commit: src/sys/dev/mii

[groo%old-ones.com@localhost (Bill Squier)]

On Sun, Feb 27, 2005 at 12:38:31PM -0500, Perry E. Metzger wrote:
> Jason Thorpe <thorpej%shagadelic.org@localhost> writes:
> >> Log Message:
> >> Don't leave blanks at the end of the "generated from:"
> >> Also, don't print a space after "},"s at the end of line in one of the
> >> files.
> >
> > I simply can't believe this.  This issue is currently being discussed
> > with core@ as to it's appropriateness, and you have been asked to
> > stop, yet you continue your rampage against whitespace.
> >
> > I am asking core/admins to disable your CVS access immediately until
> > this issue is resolved.
> 
> I said in public (well, ICB) that I was going to finish cleaning up
> the directories I had already done so that they weren't left in a half
> state, and stop. It was another dozen files out of hundreds.

The real problem here comes not from an extra argument to `cvs diff' but
spurious conflicts during imports.  From a cursory reading of some of the
affected files, it appears that some of them are maintained this way.  Correct
me if I'm wrong.

Of course, the notion that all other problems can be elimintated by simply
adding an argument to `cvs diff' also misses the point.  You can not
specify on the cvs command line how cvs determines conflicts when committing.

We've seen time and time again how random sweeps of code, while well meaning,
usually have negative effects.  I'm not sure what the positive ones are
here.  They seem akin to that nagging feeling you might get that the
refrigerator light doesn't go out when you close the door.

-- 
Bill Squier (groo%old-ones.com@localhost)                          
http://www.netbsd.org

        I know I don't deserve another chance, but this _is_ America,
        and as an American, aren't I entitled to one?  --Sideshow Bob.