Re: CVS commit: src/sys/dev/pci

[Jason Thorpe <thorpej%shagadelic.org@localhost>]

On Feb 15, 2006, at 5:09 PM, Gavan Fantom wrote:

> I'll convert this to device properties.

Great, thanks.

> Would it be best to create properties for MAC address, cfg1, cfg2  
> and swdpin, or would it be better to allow MD code to copy (or  
> construct) the entire EEPROM into device properties and let the  
> driver choose the bits it needs (and may need in the future)?

Hm, that's a tricky one.

Off-hand, I'd say probably the best way to do this would be:

mac-address             Ethernet address
i82543-cfg1             CFG1 value
i82543-cfg2             CFG2 value
i82543-swdpin           SWDPIN value

I'm not particularly keen on constructing an entire EEPROM blob for  
an Ethernet chip in platform-specific code.

Besides, individual properties gives you the flexibility to use e.g.  
an implementation-specific SWDPIN value even if the device has an  
otherwise valid EEPROM.

-- thorpej