Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci



Jason Thorpe wrote:

Off-hand, I'd say probably the best way to do this would be:

mac-address        Ethernet address
i82543-cfg1        CFG1 value
i82543-cfg2        CFG2 value
i82543-swdpin        SWDPIN value

That's the way I'm leaning, too.

I'm not particularly keen on constructing an entire EEPROM blob for an Ethernet chip in platform-specific code.

Besides, individual properties gives you the flexibility to use e.g. an implementation-specific SWDPIN value even if the device has an otherwise valid EEPROM.

Not really, unless there's a way to tie properties to a specific *instance* of the driver.

The properties are a fallback in case the checksum fails. This allows for the scenario where you have one (EEPROM-less) wm chip integrated into the motherboard, and a PCI add-on card also with a wm chip on it.



Home | Main Index | Thread Index | Old Index