CVS commit: [chap-midi] src/sys/dev

[Chapman Flack <chap%netbsd.org@localhost>]

Module Name:    src
Committed By:   chap
Date:           Sat May 20 03:14:12 UTC 2006

Modified Files:
        src/sys/dev [chap-midi]: midi.c midivar.h sequencer.c

Log Message:
Take open modes seriously: do not write if not open for writing, or read
if not open for reading, or if the midi device cannot read. In sequencer,
open only the midi devices that support at least one of the open modes
wanted; so, if the sequencer is opened for reading only, do not bother
opening midi devices that cannot input. Do not write anything to the
midi devices if opened for reading only; seq_reset previously wrote a
bunch of initial settings, which could lead to long timeouts in seq_drain
on close because of data in the output buffer that could not go anywhere.

TODO: sending initial settings is the less important thing for seq_reset
to do; the most important is to reset the buffers so the playing stops!
At present, it doesn't do that at all.


To generate a diff of this commit:
cvs rdiff -r1.43.2.3 -r1.43.2.4 src/sys/dev/midi.c
cvs rdiff -r1.11.14.3 -r1.11.14.4 src/sys/dev/midivar.h
cvs rdiff -r1.30.14.3 -r1.30.14.4 src/sys/dev/sequencer.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.