Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



On Sun, Oct 29, 2006 at 10:22:27PM +0900, Izumi Tsutsui wrote:
> dyoung%pobox.com@localhost wrote:
> 
> > BUS_DMA_COHERENT is advice for the bus_dma backend.  The backend may
> > ignore it.  Quoting bus_dma(9),
> 
> Yes, I know it's just a hint, and that was a reason why I put
> BUS_DMA_COHERENT _after_ I tweaked descriptor accesses and put
> necessary bus_dmamap_sync() calls.
> 
> Anyway, there are quite few (no?) drivers which will work
> without the hint on non DMA cache coherent systems.
> (i.e. most drivers lack some of required bus_dmamap_sync(9) calls
>  especially against DMA descriptors)

Ok.  I was pretty sure that ath, atw, rtw, sip, and tlp properly
synchronized descriptors.  I hope that people will file PRs against those
drivers that do not.  I intended to get the synchronization absolutely
correct with atw and rtw, but I may still have botched it.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933



Home | Main Index | Thread Index | Old Index