Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



thorpej%shagadelic.org@localhost wrote:

> > (though rtl8169.c should have some flag which indicates RTL8168 quirk,
> >  which can't xfer RX packets into unaligned buffers)
> 
> So, we'd have a RE_ETHER_ALIGN(sc) macro that wraps it?  Sounds good.

To handle RTL8168 on !__NO_STRICT_ALIGNMENT hosts case,
we have to copy RX DMA buffer (which is word align)
to a new mbuf with ETHER_ALIGN padding, as other drivers
(vr(4), tlp(4), vge(4) etc.) does, IIUC.

I wonder which is more efficient way to copy received buffer,
allocating a new mbuf, or moving data toward 2 bytes in the
same mbuf, which is used in vge(4).
---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index