tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Building FILES?



On Sun, 19 Oct 2008, Aleksey Cheusov wrote:
> > Also, it's conventional to use ".", not "_", in the variable name:
> 
> >     FILESBUILD.tralala = yes
> 
> bsd.README:
> 
>  FILESOWN_<fn>   File owner of the specific file <fn>.
> 
>  FILESGRP_<fn>   File group of the specific file <fn>.
   [...]
> Is all this for historical reasons?

Oh, I see.  bsd.files.mk uses "_" in variable names for the same purpose
that most other bsd.*.mk use ".". Yes, probably for historical reasons.

> P.S.
> Can anybody please fix
> 
>     pkg/39715 [serious/high]: bmake: bug in bsd.files.mk
> 
> This relates to pkgsrc.

The patch in that PR causes the behaviour and the comments to disagree
with each other (comment says that FILES variable is cleared, but code
doesn't clear it).  Also, I think we need to research the reasons for
the old behaviour before changing it.

--apb (Alan Barrett)


Home | Main Index | Thread Index | Old Index