tech-userlevel archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Building FILES?



 >> P.S.
 >> Can anybody please fix
 >> 
 >>     pkg/39715 [serious/high]: bmake: bug in bsd.files.mk
 >> 
 >> This relates to pkgsrc.

> The patch in that PR causes the behaviour and the comments to
> disagree with each other (comment says that FILES variable is
> cleared, but code doesn't clear it).
Yes, comment should be removed too.

> Also, I think we need to research the reasons for the old behaviour
> before changing it.
If I understand correctly the only purpose of FILES:= at the end of file
is to allow multiple inclusion of bsd.files.mk, as comment says.
NetBSD's /usr/share/mk/bsd.files.mk uses the same approach
as in proposed patch.

-- 
Best regards, Aleksey Cheusov.


Home | Main Index | Thread Index | Old Index