INSTALL_LARGE build failure

["Chavdar Ivanov" <ci4ic4%gmail.com@localhost>]

Hi,

I haven't been able to build.sh release for a few days due to :-

#   compile  INSTALL_LARGE/clock.o
/f/tools/bin/i386--netbsdelf-gcc -ffreestanding
-fno-zero-initialized-in-bss -march=i486 -mtune=i486 -Os -Werror -Wall
-Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes
-Wstrict-prototypes -Wswitch -Wshadow -Wcast-qual -Wwrite-strings
-Wno-sign-compare -Wno-pointer-sign -Wno-attributes -Wextra
-Wno-unused-parameter -fno-strict-aliasing -Di386 -I.
-I/usr/src/sys/contrib/dev/ath/netbsd -I/usr/src/sys/../common/include
-I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DMAXUSERS=2 -D_KERNEL
-D_KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string
-c /usr/src/sys/arch/x86/isa/clock.c
cc1: warnings being treated as errors
/usr/src/sys/arch/x86/isa/clock.c:559: warning: no previous prototype
for 'sysbeepdetach'
/usr/src/sys/arch/x86/isa/clock.c: In function 'sysbeepdetach':
/usr/src/sys/arch/x86/isa/clock.c:561: error: 'ppi_attached'
undeclared (first use in this function)
/usr/src/sys/arch/x86/isa/clock.c:561: error: (Each undeclared
identifier is reported only once
/usr/src/sys/arch/x86/isa/clock.c:561: error: for each function it appears in.)

*** Failed target:  clock.o
*** Failed command: echo '# ' "compile INSTALL_LARGE/clock.o"; echo
/f/tools/bin/i386--netbsdelf-gcc -ffreestanding
-fno-zero-initialized-in-bss -march=i486 -mtune=i486 -Os -Werror -Wall
-Wno-main -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes
-Wstrict-prototypes -Wswitch -Wshadow -Wcast-qual -Wwrite-strings
-Wno-sign-compare -Wno-pointer-sign -Wno-attributes -Wextra
-Wno-unused-parameter -fno-strict-aliasing -Di386 -I.
-I/usr/src/sys/contrib/dev/ath/netbsd -I/usr/src/sys/../common/include
-I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DMAXUSERS=2 -D_KERNEL
-D_KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string
-c /usr/src/sys/arch/x86/isa/clock.c; /f/tools/bin/i386--netbsdelf-gcc
-ffreestanding -fno-zero-initialized-in-bss -march=i486 -mtune=i486
-Os -Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith
-Wmissing-prototypes -Wstrict-prototypes -Wswitch -Wshadow -Wcast-qual
-Wwrite-strings -Wno-sign-compare -Wno-pointer-sign -Wno-attributes
-Wextra -Wno-unused-parameter -fno-strict-aliasing -Di386 -I.
-I/usr/src/sys/contrib/dev/ath/netbsd -I/usr/src/sys/../common/include
-I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DMAXUSERS=2 -D_KERNEL
-D_KERNEL_OPT -I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/i386/string
-c /usr/src/sys/arch/x86/isa/clock.c

I though it was something stale in my local copy, so I persisted a few
times with cvs update, without success.

This morning I had a look - AFAIU it looks like a missplaced #endif.
The following sorted this out for me:

Index: sys/arch/x86/isa/clock.c
===================================================================
RCS file: /cvsroot/src/sys/arch/x86/isa/clock.c,v
retrieving revision 1.17
diff -u -r1.17 clock.c
--- sys/arch/x86/isa/clock.c    3 Jan 2008 04:50:19 -0000       1.17
+++ sys/arch/x86/isa/clock.c    4 Jan 2008 09:55:39 -0000
@@ -552,7 +552,6 @@
        if (!pmf_device_register(self, NULL, NULL))
                aprint_error_dev(self, "couldn't establish power handler\n");
 }
-#endif

 int
 sysbeepdetach(device_t self, int flags)
@@ -561,6 +560,7 @@
        ppi_attached = 0;
        return 0;
 }
+#endif

 void
 sysbeep(int pitch, int period)




-- 
----------------------------------------------------------------
/dev/random says:
      Beware of programmers who carry screwdrivers.
----------------------------------------------------------------
Chavdar Ivanov   | Talbot Way, Small Heath Business Park
Delcam UK        | Birmingham B10 0HJ, United Kingdom
Customer Support | (+44)121-6831014
----------------------------------------------------------------