Re: getmntinfo compatibility question

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Feb 14, 2025 at 11:59:33AM +0100, Havard Eidnes wrote:
> Now, backing off that for a bit, and returning to the original
> question, the "90" suffix used with statvfs*() appears to me to
> indicate that this rename was done in the era leading up to the
> NetBSD 9.0 release.  Since we do not support any older release than
> 9.0 (and barely that...) with rust, we should perhaps take steps to
> adopt the new ABI instead.  This means the struct above needs to be
> amended/extended and we need to ensure that we call the right
> version of the libc function.

No, it means that the symbol is the version from NetBSD 9 - the change
to the extended struct statvfs was done between NetBSD 9 and 10.

So we could switch to the new version, but it would mean adding NetBSD
version checks to the libc crate (it's not hard, but these don't exist
yet for NetBSD) and supporting both versions there.

I think we should just wait for NetBSD 9 to be desupported and switch
to it then.

> And ... since the rust compiler distribution has multiple versions
> of the libc crate embedded, we need to figure out how many of them
> need to be fixed, and then we need to get the rust folks to adopt
> the modification, so that we eventually down the road can stop
> maintaining that as a diff in our package.

On it! At least for the getmntinfo fix:

https://github.com/rust-lang/libc/pull/4265

I only noticed getmntinfo usage in one crate so far, trash-rs.
 Thomas