Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: jobs -l no longer shows process IDs in /bin/csh under NetBSD-10.99.12



On Tue, 18 Mar 2025, Brian Buhrow wrote:

Unfortunately, after I applied it, there is no change in the
shell behavior.
Just to make sure I applied it right, here's the diff against V1.42 of proc.c.

Hmm. That doesn't look like my patch, which _specifically_ removes that
`if (v[1])' test causing your issue.

The actual changes are quite minimal. Here they are:

```
diff -wurN a/src/bin/csh/err.c b/src/bin/csh/err.c
--- a/src/bin/csh/err.c	2022-04-08 10:17:52.000000000 +0000
+++ b/src/bin/csh/err.c	2025-03-18 04:31:04.359583932 +0000
@@ -171,7 +171,7 @@
 #define ERR_STRING	56
     "%s",
 #define ERR_JOBS	57
-    "usage: jobs [ -lZ ]",
+    "usage: jobs [-l|-Z [title]]",
 #define ERR_JOBARGS	58
     "Arguments should be jobs or process id's",
 #define ERR_JOBCUR	59
diff -wurN a/src/bin/csh/proc.c b/src/bin/csh/proc.c
--- a/src/bin/csh/proc.c	2021-09-16 19:34:21.000000000 +0000
+++ b/src/bin/csh/proc.c	2025-03-18 04:12:46.363000567 +0000
@@ -842,8 +842,7 @@
     if (chkstop)
 	chkstop = 2;
     if (*++v) {
-	if (v[1]) {
-	    if (eq(*v, STRml)) {
+	if (eq(*v, STRml) && !v[1]) {
 		flag |= FANCY | JOBDIR;
 	    } else if (eq(*v, STRmZ)) {
 		if (v[1] && v[1][0]) {
@@ -856,7 +855,6 @@
 		stderror(ERR_JOBS);
 	    }
 	}
-    }
     for (i = 1; i <= pmaxindex; i++)
 	for (pp = proclist.p_next; pp; pp = pp->p_next)
 	    if (pp->p_index == i && pp->p_pid == pp->p_jobid) {
```

This was created using `diff -w', so may not apply automatically. Should be
super easy to apply by hand, then fix the (now) extra whitespace.

-RVP


Home | Main Index | Thread Index | Old Index