Re: kern/53217: -current: dumping to wedges on GPT disks broken

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/53217; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
Date: Fri, 27 Apr 2018 15:15:03 -0000 (UTC)

 kardel%netbsd.org@localhost writes:
 
 >Machine: amd64
 >>Description:
 >	dumping on a swap wedge from a GPT partitioned disk fails with
 >	dump: device bad
 
 >	caused by: dksubr.c:dk_dump():806
 >    806         p = &lp->d_partitions[part];
 >    807         if (p->p_fstype != FS_SWAP) {
 >    808                 DPRINTF(DKDB_DUMP, ("%s: bad fstype %d\n", __func__,
 >    809                     p->p_fstype));
 >    810                 return ENXIO;
 >    811         }
 
 
 The wedge references the RAW_PART of the parent disk, which rarely has
 a valid fstype.
 
 So adding the case RAW_PART && FS_UNUSED as allowed should fix the
 issue.
 
 -- 
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."