Re: kern/53217: -current: dumping to wedges on GPT disks broken

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/53217; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, kardel%netbsd.org@localhost
Cc: 
Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
Date: Fri, 27 Apr 2018 11:35:25 -0400

 On Apr 27,  2:45pm, kardel%netbsd.org@localhost (Frank Kardel) wrote:
 -- Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
 
 |  That would be the dump functions in the disk drivers, but that have the 
 |  same problem as parent devices, they would still be looking at "whole 
 |  disk" in the GPT case. In the GPT case only dkwedge/dk.c knows about the 
 |  swap type. In the BSD label case the check would make sense.
 |  The check would only be valid for non whole disk partitions in the disk 
 |  drivers or even in this place or am I missing something?
 
 I think that we should either fix the wedge code to create a better
 fictitious disklabel or get rid of the label code and have it just
 be there for compatibility (replacing dk_label with something that
 works in all cases).
 
 christos