kern/57129: DIAGNOSTIC is defined in amd64 GENERIC kernel

[lloyd%must-have-coffee.gen.nz@localhost]

>Number:         57129
>Category:       kern
>Synopsis:       DIAGNOSTIC is defined in amd64 GENERIC kernel
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 21 22:40:00 +0000 2022
>Originator:     Lloyd Parkes
>Release:        10.0_BETA
>Organization:
Must Have Coffee
>Environment:
NetBSD ceph4.must-have-coffee.gen.nz 10.0_BETA NetBSD 10.0_BETA (GENERIC) #2: Wed Dec 21 12:02:20 NZDT 2022  lloyd%ceph4.must-have-coffee.gen.nz@localhost:/home/lloyd/NetBSD/objdir/sys/arch/amd64/compile/GENERIC amd64
>Description:
sys/arch/amd64/conf/GENERIC defines the kernel option DIAGNOSTIC, which has a comment next to it that says "XXX to be commented out on release branch".

We are on a release branch and it hasn't been commented out.

This is a serious problem because the new ACPI code will drop into DDB with no functional keyboard if some sanity checks fail when DIAGNOSTIC is defined and will simply ignore "insane" devices otherwise. 

>How-To-Repeat:
Boot 10.0_BETA on an Intel S1200RPx motherboard.
>Fix:
Comment out the DIAGNOSTIC option. Also add this task to whatever documentation releng has for branching NetBSD. Maybe even automate it?