NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC static binary

The following reply was made to PR kern/59100; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Fri, 28 Feb 2025 11:07:16 -0500

 --Apple-Mail=_38DEEA2B-EA3A-4037-8546-EE3ADAF66F27
 Content-Type: multipart/alternative;
 	boundary="Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185"
 
 
 --Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 Is the below still needed?
 
 
 --- /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig	2025-02-24 =
 20:10:38.789270837 +0100
 +++ /usr/src/sys/compat/netbsd32/netbsd32_signal.c	2025-02-24 =
 20:12:37.675593950 +0100
 @@ -209,7 +209,7 @@
 			/*
 			 * Module is already loaded and locked in memory
 			 */
 -			sigcontext_valid =3D =
 netbsd32_sendsig_sigcontext_16_hook.hooked;
 +			sigcontext_valid =3D 1;
 		}
 		if (!sigcontext_valid) {
 			return EINVAL;
 
 Or is the following enough?
 
 
 --- /sys/compat/netbsd32/netbsd32_compat_16.c.orig	2025-02-26 =
 10:49:56.871640011 +0100
 +++ /sys/compat/netbsd32/netbsd32_compat_16.c	2025-02-27 =
 22:10:57.245055044 +0100
 @@ -52,7 +52,7 @@
  #define __HAVE_MD_NETBSD32_SIGRETURN14
  #endif
 
 -#if defined(__arm__) || defined(__mips__) || defined(__powerpc__) || =
 defined(__riscv__)
 +#if defined(__amd64__) || defined(__arm__) || defined(__mips__) || =
 defined(__powerpc__) || defined(__riscv__)
  #define __HAVE_MD_NETBSD32_SIGCODE
  #endif
 
 christos=
 
 --Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html;
 	charset=us-ascii
 
 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
 charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
 -webkit-nbsp-mode: space; line-break: after-white-space;">Is the below =
 still needed?<br id=3D"lineBreakAtBeginningOfMessage"><div><br><font =
 color=3D"#5856d6"><span style=3D"caret-color: rgb(88, 86, =
 214);"><br></span></font>--- =
 /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>2025-02-24 20:10:38.789270837 +0100<br>+++ =
 /usr/src/sys/compat/netbsd32/netbsd32_signal.c<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>2025-02-24 20:12:37.675593950 +0100<br>@@ -209,7 +209,7 =
 @@<br><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>/*<br><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span> * Module is already loaded and locked in memory<br><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span> =
 */<br>-<span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>sigcontext_valid =3D =
 netbsd32_sendsig_sigcontext_16_hook.hooked;<br>+<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	</span><span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>sigcontext_valid =3D 1;<br><span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span><span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span>}<br><span class=3D"Apple-tab-span"=
  style=3D"white-space: pre;">	</span><span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span>if (!sigcontext_valid) =
 {<br><div><div> <span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span><span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span>return EINVAL;<br></div></div></div><br><div>Or is the following =
 enough?</div><div><br></div><div><br>--- =
 /sys/compat/netbsd32/netbsd32_compat_16.c.orig<span =
 class=3D"Apple-tab-span" style=3D"white-space: pre;">	=
 </span>2025-02-26 10:49:56.871640011 +0100<br>+++ =
 /sys/compat/netbsd32/netbsd32_compat_16.c<span class=3D"Apple-tab-span" =
 style=3D"white-space: pre;">	</span>2025-02-27 22:10:57.245055044 =
 +0100<br>@@ -52,7 +52,7 @@<br>&nbsp;#define =
 __HAVE_MD_NETBSD32_SIGRETURN14<br>&nbsp;#endif<br><br>-#if =
 defined(__arm__) || defined(__mips__) || defined(__powerpc__) || =
 defined(__riscv__)<br>+#if defined(__amd64__) || defined(__arm__) || =
 defined(__mips__) || defined(__powerpc__) || =
 defined(__riscv__)<br>&nbsp;#define =
 __HAVE_MD_NETBSD32_SIGCODE<br>&nbsp;#endif<br></div><div><br></div><div>ch=
 ristos</div></body></html>=
 
 --Apple-Mail=_30FE289C-6F64-40BC-9A72-0A9019E14185--
 
 --Apple-Mail=_38DEEA2B-EA3A-4037-8546-EE3ADAF66F27
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCZ8HfNAAKCRBxESqxbLM7
 OvUwAKCktH5I6ElTv+OBWDIpkG69UoOI4ACbB1w1ha5FxP6ymjUzzdR3mq+IGKw=
 =2cl3
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_38DEEA2B-EA3A-4037-8546-EE3ADAF66F27--
Home | Main Index | Thread Index | Old Index