Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC static binary

["Onno van der Linden via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59100; it has been noted by GNATS.

From: Onno van der Linden <o.vd.linden%quicknet.nl@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: christos%netbsd.org@localhost
Subject: Re: kern/59100: compat fixes from Nov 22 2024 break cvsup 1.6ZC
 static binary
Date: Fri, 28 Feb 2025 17:53:44 +0100

 On Fri, Feb 28, 2025 at 04:10:04PM +0000, Christos Zoulas via gnats wrote:
 >  Is the below still needed?
 
 No, absolutely not. sigcontext_valid = 1 was just a workaround,
 not a correct fix.
 
 >  
 >  
 >  --- /usr/src/sys/compat/netbsd32/netbsd32_signal.c.orig	2025-02-24 =
 >  20:10:38.789270837 +0100
 >  +++ /usr/src/sys/compat/netbsd32/netbsd32_signal.c	2025-02-24 =
 >  20:12:37.675593950 +0100
 >  @@ -209,7 +209,7 @@
 >  			/*
 >  			 * Module is already loaded and locked in memory
 >  			 */
 >  -			sigcontext_valid =3D =
 >  netbsd32_sendsig_sigcontext_16_hook.hooked;
 >  +			sigcontext_valid =3D 1;
 >  		}
 >  		if (!sigcontext_valid) {
 >  			return EINVAL;
 >  
 >  Or is the following enough?
 
 Yes, this is the correct fix. I'm running with it on my system
 and cvsup works correct.
 
 >  
 >  
 >  --- /sys/compat/netbsd32/netbsd32_compat_16.c.orig	2025-02-26 =
 >  10:49:56.871640011 +0100
 >  +++ /sys/compat/netbsd32/netbsd32_compat_16.c	2025-02-27 =
 >  22:10:57.245055044 +0100
 >  @@ -52,7 +52,7 @@
 >   #define __HAVE_MD_NETBSD32_SIGRETURN14
 >   #endif
 >  
 >  -#if defined(__arm__) || defined(__mips__) || defined(__powerpc__) || =
 >  defined(__riscv__)
 >  +#if defined(__amd64__) || defined(__arm__) || defined(__mips__) || =
 >  defined(__powerpc__) || defined(__riscv__)
 >   #define __HAVE_MD_NETBSD32_SIGCODE
 >   #endif
 
 Onno