Re: rump vs. smbfs

[Nicolas Joly <njoly%pasteur.fr@localhost>]

On Thu, Jul 02, 2009 at 10:44:29PM +0100, Matthias Scheler wrote:
> 
> On 2 Jul 2009, at 22:25, Nicolas Joly wrote:
> >>
> >>Any chance to commit your directory opening patch as well?
> >
> >I'll do.
> 
> Thank you.
> 
> >I just want to check a few things before ...

The previous patch was not correct. It was reverting to the basic
open; if the NT capabilities are supported, it should use
NT_CREATE_ANDX command.

Attached the new version i plan to commit later today unless i do find
some other problems.

-- 
Nicolas Joly

Biological Software and Databanks.
Institut Pasteur, Paris.

Index: src/sys/fs/smbfs/smbfs_vnops.c
===================================================================
RCS file: /cvsroot/src/sys/fs/smbfs/smbfs_vnops.c,v
retrieving revision 1.69
diff -u -p -r1.69 smbfs_vnops.c
--- src/sys/fs/smbfs/smbfs_vnops.c      23 Jun 2009 19:36:39 -0000      1.69
+++ src/sys/fs/smbfs/smbfs_vnops.c      3 Jul 2009 09:56:10 -0000
@@ -227,11 +227,9 @@ smbfs_open(void *v)
                return EACCES;
        }
        if (vp->v_type == VDIR) {
-               if ((sv_caps & SMB_CAP_NT_SMBS) == 0) {
-                       np->n_flag |= NOPEN;
+               np->n_flag |= NOPEN;
+               if ((sv_caps & SMB_CAP_NT_SMBS) == 0)
                        return 0;
-               }
-
                goto do_open;   /* skip 'modified' check */
        }