pkg/27238: games/tads - bad MASTER_SITES definition & need a DIST_SUBDIR

[kre%munnari.OZ.AU@localhost]

>Number:         27238
>Category:       pkg
>Synopsis:       games/tads - bad MASTER_SITES definition & need a DIST_SUBDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 12 18:14:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Robert Elz
>Release:        NetBSD 1.6X   pjgsrc current as of date/time of this mail)
>Organization:
        Prince of Songkla University
>Environment:
Architecture: i386
Machine: i386
>Description:
        The recently upgraded games/tads package as an error in the
        MASTER_SITES definition, which results in the distfile always
        being fetched from a backup site.   This would normally simply
        fail, but here the distfile name forthe previous version of the
        package is identical for that of the new package, and the backup
        sites all (well, enough anyway, maybe all, I didn't check) have
        that old version of the pkg distfile.   pkgsrc dutifully fetches
        that, and fails the checksum test (naturally).
>How-To-Repeat:
        cd ..../pkgsrc/games/tads
        make distclean
        make checksum

        Observe the failure to fgetch from the master site, followed
        by a successful transfer from a backup site (fi for me) followed
        by a checksum failure.

>Fix:
        Apply the following patch to sorrect the MASTER_SITES error.

        But the Makefile also needs DIST_SUBDIR set, so the
        distfile will go somewhere different than where the old one
        was placed (which I assume, without looking, also affects its
        placement on the netbsd based backup master sites at least).

        I didn't include that, as I have no idea what the pkgsrc people
        would prefer it to be called...

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/games/tads/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile    8 Oct 2004 23:14:37 -0000       1.7
+++ Makefile    12 Oct 2004 18:03:58 -0000
@@ -4,7 +4,7 @@
 DISTNAME=      tads23-unix
 PKGNAME=       tads-3.0.7
 CATEGORIES=    games
-MASTER_SITES=  http://www.tads.org/t3dl
+MASTER_SITES=  http://www.tads.org/t3dl/
 
 MAINTAINER=    dillo%NetBSD.org@localhost
 HOMEPAGE=      http://www.tads.org/
>Release-Note:
>Audit-Trail:
>Unformatted: