pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/35026 (new option for pkg_chk for using SU_CMD from mk.conf)
The following reply was made to PR pkg/35026; it has been noted by GNATS.
From: Roland Illig <rillig%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc:
Subject: Re: pkg/35026 (new option for pkg_chk for using SU_CMD from mk.conf)
Date: Thu, 21 Dec 2006 00:07:55 +0100
Aleksey Cheusov wrote:
> The following reply was made to PR pkg/35026; it has been noted by GNATS.
>
> From: Aleksey Cheusov <cheusov%tut.by@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: abs%NetBSD.org@localhost, pkgsrc-bugs%NetBSD.org@localhost,
> gnats-admin%NetBSD.org@localhost
> Subject: Re: pkg/35026 (new option for pkg_chk for using SU_CMD from
> mk.conf)
> Date: Wed, 20 Dec 2006 23:13:23 +0200
>
> > Would having pkg_chk automatically use SU_CMD if the user is non root
> cover
> > your needs? something like:
>
> The patch looks fine except:
> 1) I'm not sure about unpriviledged builds;
> 2) s/!=/==/
> 3) I would prefer to double quote `id -u`, id program may fail (who knows),
> Interix allows user names with spaces inside.
>
> > +if [ `${ID} -u` != 0 ] ; then
> +if [ "`${ID} -u`" == 0 ] ; then
s/==/-eq/
;)
Roland
Home |
Main Index |
Thread Index |
Old Index