pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/35026 (new option for pkg_chk for using SU_CMD from mk.conf)



 >>  The patch looks fine except:
 >>  1) I'm not sure about unpriviledged builds;
 >>  2) s/!=/==/
 >>  3) I would prefer to double quote `id -u`, id program may fail (who knows),
 >>     Interix allows user names with spaces inside.
 >>  
 >>  > +if [ `${ID} -u` != 0 ] ; then
 >>    +if [ "`${ID} -u`" == 0 ] ; then
>  
>  s/==/-eq/
>  
>  ;)

Ah!
I forgot about resent anti-bashit thread, sorry :)
Single = is enough.

-- 
Best regards, Aleksey Cheusov.



Home | Main Index | Thread Index | Old Index