Re: pkg/35026 (new option for pkg_chk for using SU_CMD from mk.conf)

[Aleksey Cheusov <cheusov%tut.by@localhost>]

The following reply was made to PR pkg/35026; it has been noted by GNATS.

From: Aleksey Cheusov <cheusov%tut.by@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: abs%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
pkgsrc-bugs%NetBSD.org@localhost
Subject: Re: pkg/35026 (new option for pkg_chk for using SU_CMD from
 mk.conf)
Date: Thu, 21 Dec 2006 20:14:05 +0200

  >>  The patch looks fine except:
  >>  1) I'm not sure about unpriviledged builds;
  >>  2) s/!=/==/
  >>  3) I would prefer to double quote `id -u`, id program may fail (who 
knows),
  >>     Interix allows user names with spaces inside.
  >>  
  >>  > +if [ `${ID} -u` != 0 ] ; then
  >>    +if [ "`${ID} -u`" == 0 ] ; then
 >  
 >  s/==/-eq/
 >  
 >  ;)
 
 Ah!
 I forgot about resent anti-bashit thread, sorry :)
 Single = is enough.
 
 -- 
 Best regards, Aleksey Cheusov.