Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0))

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

The following reply was made to PR pkg/40039; it has been noted by GNATS.

From: Bernd Ernesti <netbsd%lists.veego.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0))
Date: Sun, 7 Dec 2008 15:37:44 +0100

 On Sat, Nov 29, 2008 at 09:06:35AM -0500, Jared D. McNeill wrote:
 > Does the following patch work for you?
 
 Hmm, it looks like that will work for NetBSD < 5 but I think you will get
 problems during a pkg_delete for NetBSD 5 and FreeBSD due too the way
 how the PLIST files are handled.
 
 - PLIST
 @dirrm lib/hal/scripts
 @dirrm lib/hal
 
 - PLIST.FreeBSD
 @dirrm lib/hal/scripts/freebsd
 
 - PLIST.NetBSD
 @dirrm lib/hal/scripts/netbsd
 
 The @dirrm will be executed in the order of the generated PLIST file,
 so the @dirrm from PLIST come before the '@dirrm lib/hal/scripts/*'
 in PLIST.NetBSD or PLIST.FreeBSD. The @dirrm from PLIST will fail because
 there are still files/directories left in the lib/hal/scripts.
 
 IMHO there are three options:
 
 1. Don't use your patch and only add a 'PLIST_SRC= PLIST' in the
    NetBSD < 5 case
 2. Use your patch and do the following modifications.
    Add a PLIST.common_end file where at least the two lines from the
    PLIST file for '@dirrm lib/hal' and '@dirrm lib/hal/scripts'
    has to be moved to that file (where it would be better to move
    all @dirrm from PLIST to that file). Then add the new file after
    the Linux check with 'PLIST_SRC+= PLIST.common_end'.
    This mimics the behaviour in pkgsrc/mk/plist/plist.mk
 3. It could work to use 'PLIST_SRC= PLIST.FreeBSD' and
    'PLIST_SRC= PLIST.NetBSD' and use 'PLIST_SRC+= PLIST' after
    the NetBSD (or Linux) check.
 
 Note that I haven't tested anything, I only looked at the PLIST files.
 
 Bernd