Re: pkg/42043: Installing sysutils/libgtop with USE_DESTDIR results in wrong setgid binary

[Joachim Kuebart <joachim.kuebart%gmx.net@localhost>]

The following reply was made to PR pkg/42043; it has been noted by GNATS.

From: Joachim Kuebart <joachim.kuebart%gmx.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/42043: Installing sysutils/libgtop with USE_DESTDIR
 results in wrong setgid binary
Date: Fri, 11 Sep 2009 00:51:47 +0100

 Here is an additional patch that uses SPECIAL_PERMS.
 
 If this is applied, I think that patches/patch-da should still be
 replaced by the above version because otherwise the build process
 modifies files that are currently installed on the system (i.e. in
 ${PREFIX}, but outside ${DESTDIR}).
 
 Index: Makefile
 ===================================================================
 RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/libgtop/Makefile,v
 retrieving revision 1.28
 diff -p -U8 -r1.28 Makefile
 --- Makefile   27 Aug 2009 20:03:17 -0000      1.28
 +++ Makefile   11 Sep 2009 00:48:20 -0000
 @@ -54,18 +54,17 @@ PLIST_VARS+=       server suid.h
  .elif ${OPSYS} == "SunOS"
  PLIST.server= yes
  .else
  PLIST.server= yes
  PLIST.suid.h= yes
  .endif
  
  .if defined(PLIST.server)
 -post-install:
 -      ${CHMOD} g+s ${DESTDIR}${PREFIX}/bin/libgtop_server2
 +SPECIAL_PERMS+=               bin/libgtop_server2 ${REAL_ROOT_USER} kmem 2555
  .endif
  
  PLIST_VARS+=    glibtop_private.h
  .if ${OPSYS} == "Linux" || ${OPSYS} == "SunOS" || ${OPSYS} == "FreeBSD" || 
${OPSYS} == "DragonFly"
  PLIST.glibtop_private.h= yes
  .endif
  
  # XXX This needs a check in the configure script, which should be clean