Re: pkg/45042: devel/bmake minix support

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/45042; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/45042: devel/bmake minix support
Date: Sun, 12 Jun 2011 05:03:30 +0000

 On Fri, Jun 10, 2011 at 02:35:00PM +0000, linuxgeek%gmail.com@localhost wrote:
  > --- a/devel/bmake/files/configure
  > +++ b/devel/bmake/files/configure
 
 please don't include huge diffs of generated files.
 
  > -# Generated by GNU Autoconf 2.64 for bmake 20100414.
  > +# Generated by GNU Autoconf 2.65 for bmake 20100414.
 
 ...especially those caused by changing the version of autoconf!
 
  > @@ -184,7 +186,7 @@ AC_ARG_WITH(force_machine,
  >  [  --with-force-machine=MACHINE  set FORCE_MACHINE],
  >  [case "${withval}" in
  >  yes)   force_machine=FORCE_;;
  > -no)    ;;
  > +no)    force_machine=NOFORCE_;;
  >  *)     force_machine=FORCE_; machine=$with_force_machine;;
  >  esac])
  >  dnl
 
 That doesn't seem right... what's it supposed to do?
 
  > diff --git a/devel/bmake/files/job.c b/devel/bmake/files/job.c
  > index c37b17e..96650ea 100644
  > --- a/devel/bmake/files/job.c
  > +++ b/devel/bmake/files/job.c
  > @@ -1380,7 +1380,7 @@ JobExec(Job *job, char **argv)
  >      * we can kill it and all its descendants in one fell swoop,
  >      * by killing its process family, but not commit suicide.
  >      */
  > -#if defined(SYSV)
  > +#if defined(SYSV) || !defined(HAVE_SETPGID)
  >     /* XXX: dsl - I'm sure this should be setpgrp()... */
  >     (void)setsid();
  >  #else
 
 That is definitely not right. (Including for "SYSV".)
 
 How do you set process groups in Minix?
 
  > -#ifdef RLIMIT_NOFILE
  > +#if defined(RLIMIT_NOFILE) && defined(HAVE_SETRLIMIT)
 
 ...so wait, Minix defines RLIMIT_NOFILE but doesn't have setrlimit()?
 How do you use RLIMIT_NOFILE then?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost