Re: pkg/45042: devel/bmake minix support

[Thomas Cort <tcort%minix3.org@localhost>]

The following reply was made to PR pkg/45042; it has been noted by GNATS.

From: Thomas Cort <tcort%minix3.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/45042: devel/bmake minix support
Date: Mon, 13 Jun 2011 12:17:57 -0400

 > =A0please don't include huge diffs of generated files.
 
 
 Sorry. It won't happen again.
 
 
 > =A0> @@ -184,7 +186,7 @@ AC_ARG_WITH(force_machine,
 > =A0> =A0[ =A0--with-force-machine=3DMACHINE =A0set FORCE_MACHINE],
 > =A0> =A0[case "${withval}" in
 > =A0> =A0yes) =A0 force_machine=3DFORCE_;;
 > =A0> -no) =A0 =A0;;
 > =A0> +no) =A0 =A0force_machine=3DNOFORCE_;;
 > =A0> =A0*) =A0 =A0 force_machine=3DFORCE_; machine=3D$with_force_machine;=
 ;
 > =A0> =A0esac])
 > =A0> =A0dnl
 >
 > =A0That doesn't seem right... what's it supposed to do?
 
 
 MACHINE is already used in minix header files. The mk-bootstrap.sh
 file has the following line:
 
 MDEFS=3D"-D@force_machine@MACHINE=3D\"@machine@\"
 -DMACHINE_ARCH=3D\"@machine_arch@\" -DMAKE_VERSION=3D\"$MAKE_VERSION\""
 
 This causes MACHINE to be redefined when --force-machine is not
 passed to the configure script. The autoconf file was changed to set
 force_machine to NOFORCE_ when --force-machine is not passed.
 
 
 > =A0> diff --git a/devel/bmake/files/job.c b/devel/bmake/files/job.c
 > =A0> index c37b17e..96650ea 100644
 > =A0> --- a/devel/bmake/files/job.c
 > =A0> +++ b/devel/bmake/files/job.c
 > =A0> @@ -1380,7 +1380,7 @@ JobExec(Job *job, char **argv)
 > =A0> =A0 =A0 =A0* we can kill it and all its descendants in one fell swoo=
 p,
 > =A0> =A0 =A0 =A0* by killing its process family, but not commit suicide.
 > =A0> =A0 =A0 =A0*/
 > =A0> -#if defined(SYSV)
 > =A0> +#if defined(SYSV) || !defined(HAVE_SETPGID)
 > =A0> =A0 =A0 /* XXX: dsl - I'm sure this should be setpgrp()... */
 > =A0> =A0 =A0 (void)setsid();
 > =A0> =A0#else
 >
 > =A0That is definitely not right. (Including for "SYSV".)
 >
 > =A0How do you set process groups in Minix?
 
 
 Minix doesn't have job control, and no process group other than
 that implemented by setsid().
 
 
 > =A0> -#ifdef RLIMIT_NOFILE
 > =A0> +#if defined(RLIMIT_NOFILE) && defined(HAVE_SETRLIMIT)
 >
 > =A0...so wait, Minix defines RLIMIT_NOFILE but doesn't have setrlimit()?
 > =A0How do you use RLIMIT_NOFILE then?
 
 RLIMIT_NOFILE can be used with getrlimit() on Minix. You can get the
 rlimits, you just can't change them.