Re: pkg/46104: kdegames4 ALIGN defined in sys/param.h NetBSD 6.99.3 patch

[Mark Davies <mark%ecs.vuw.ac.nz@localhost>]

The following reply was made to PR pkg/46104; it has been noted by GNATS.

From: Mark Davies <mark%ecs.vuw.ac.nz@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/46104: kdegames4 ALIGN defined in sys/param.h NetBSD 6.99.3 
patch
Date: Wed, 29 Feb 2012 19:59:16 +1300

 On Tuesday 28 February 2012 01:30:04 Joerg wrote:
 >  > +#ifdef __NetBSD__
 >  > +#include <sys/param.h>
 >  > +#include <machine/param.h>
 >  > +#undef CMSG_SPACE
 >  > +#define CMSG_SPACE(l)   (ALIGN(sizeof(struct cmsghdr)) + ALIGN(l))
 >  > +#endif
 > 
 >  This doesn't make sense. ALIGN and __CMSG_ALIGN are not necessarily 
 the
 >  same. So why can't this just use CMSG_SPACE as defined in 
 sys/socket.h?
 
 This is historic.  In a previous version of the code, using the standard 
 CMSG_SPACE resulted in 
 
 misc_private.h:78: error: array bound is not an integer constant
 
 so CMSG_SPACE was redefined the same way that they were doing it for 
 MacOS.
 
 Looks like this is no longer required and the whole patch can go away.
 
 cheers
 mark