pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/46104: kdegames4 ALIGN defined in sys/param.h NetBSD 6.99.3 patch



The following reply was made to PR pkg/46104; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46104: kdegames4 ALIGN defined in sys/param.h NetBSD 6.99.3
 patch
Date: Thu, 1 Mar 2012 19:50:43 +0000

 On Wed, Feb 29, 2012 at 07:00:07AM +0000, Mark Davies wrote:
  >  >  This doesn't make sense. ALIGN and __CMSG_ALIGN are not necessarily 
  >  >  the
  >  >  same. So why can't this just use CMSG_SPACE as defined in 
  >  >  sys/socket.h?
  >  
  >  This is historic.  In a previous version of the code, using the standard 
  >  CMSG_SPACE resulted in 
  >  
  >  misc_private.h:78: error: array bound is not an integer constant
  >  
  >  so CMSG_SPACE was redefined the same way that they were doing it for 
  >  MacOS.
  >  
  >  Looks like this is no longer required and the whole patch can go away.
 
 Unfortunately, it'll still be needed for netbsd-5.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost
 


Home | Main Index | Thread Index | Old Index