Re: pkg/46570: infelicities in pkglint

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/46570; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46570: infelicities in pkglint
Date: Sun, 26 Aug 2012 20:54:54 +0000

 On Sun, Aug 26, 2012 at 02:15:04PM +0000, Thomas Klausner wrote:
  >>>  Use of uninitialized value in concatenation (.) or string at 
/usr/pkg/bin/pkglint line 4776.
  >>  
  >>  This is caused by e.g. line 38 of x11/antiright/Makefile:
  >>  
  >>     TOOLS_DEPENDS.pkg-config=      pkg-config>=0.20:../../devel/pkg-config
  >  
  >  I've fixed the warning.
 
 Thanks.
 
  >  >  this line also generates
  >  >  
  >  >     WARN: Makefile:38: Permission [set] requested for 
TOOLS_DEPENDS.pkg-config, but only [] is allowed.
  >  >  
  >  >  which seems wrong.
  >  
  >  It says that TOOLS_DEPENDS.pkg-config should not be changed by a
  >  package Makefile. Are you arguing that it should be allowed or that
  >  the error message should have some text between the brackets?
 
 Well, packages certainly need to be able to specify TOOLS_DEPENDS;
 that's practically the whole point of TOOLS_DEPENDS.
 
 Perhaps it should allow += but not =, though.
 
 I've noticed (I think) that sometimes pkglint will report that "only
 [] is allowed" but it actually accepts append, but I can't point to
 any examples.
 
 (It might also be better if it said "but no uses are allowed" instead
 of "only [] is allowed".)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost