Re: pkg/46570: infelicities in pkglint

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/46570; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46570: infelicities in pkglint
Date: Sun, 26 Aug 2012 23:11:23 +0200

 On Sun, Aug 26, 2012 at 08:55:03PM +0000, David Holland wrote:
 >   >  It says that TOOLS_DEPENDS.pkg-config should not be changed by a
 >   >  package Makefile. Are you arguing that it should be allowed or that
 >   >  the error message should have some text between the brackets?
 >  
 >  Well, packages certainly need to be able to specify TOOLS_DEPENDS;
 >  that's practically the whole point of TOOLS_DEPENDS.
 >  
 >  Perhaps it should allow += but not =, though.
 
 I guess you get the behaviour you want by changing pkgtools/files/makevars.map:
 TOOLS_DEPENDS.*         InternalList of DependencyWithPath [$system]
 to
 TOOLS_DEPENDS.*         InternalList of DependencyWithPath [$package_list]
 
 >  I've noticed (I think) that sometimes pkglint will report that "only
 >  [] is allowed" but it actually accepts append, but I can't point to
 >  any examples.
 
 That shouldn't happen any longer with 4.123. If the allowed flags were
 "au" which means append and use, then the warning was printing empty
 brackets.
  Thomas