Re: pkg/53205: archivers/heirloom-tar.out:tar.c:1021: bad if test ?

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/53205; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53205: archivers/heirloom-tar.out:tar.c:1021: bad if test ?
Date: Sun, 6 May 2018 08:53:15 +0000

 On Mon, Apr 30, 2018 at 08:55:01AM +0000, David Binderman wrote:
  >  > Did you report this upstream?
  >  
  >  Yes, twice. No answer.
  >  
  >  >pkgsrc typically does not carry patches for
  >  >such nits because of the associated maintenance cost.
  >
  >  Righto, but it doesn't look like upstream are going to fix it.
  >  
  >  BTW, this bug is the first in a set of 250 bugs I am aware of in the
  >  pkgsrc packages. This is a result of doing a mass build of all the pkgsrc
  >  with gcc compiler flag -Wlogical-op switched on.
  >  
  >  List of known bugs attached.
  >  
  >  Given that the first on the list hasn't been fixed, I'd be
  >  grateful for your advice on what to do with the rest of the list.
 
 Roll one big patch with all the fixes, send it to upstream, and then
 also post it somewhere. We can add it to pkgsrc as a patchkit, and if
 upstream is actually ignoring it (as opposed to just being comatose)
 we can worry about what to do when another release appears.
 
 (I don't get the feeling that heirloom-* is actively maintained. We do
 carry a lot of miscellaneous patches for inactively or lightly
 maintained packages.)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost