Re: pkg/56169 (modular-xorg-xephyr build problem on Solaris 10)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/56169; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/56169 (modular-xorg-xephyr build problem on Solaris 10)
Date: Sun, 22 May 2022 23:23:25 +0000

 On Thu, Jun 24, 2021 at 06:40:01PM +0000, Tobias Nygren wrote:
  >  > It builds on Linux now.
  >  > I'm am not sure if modular-xorg-server builds on SunOS.
  >  > The fix was for modular-xorg-xephyr but may or may not be necessary for
  >  > -server and may in fact break it in the same manner as it broke for
  >  > Linux. I guess in that case we can move USE_FEATURES from
  >  > Makefile.common to -xephyr/Makefile to avoid the issue.
  >  
  >  It is broken on SunOS due to this according to bulk builds:
  >  
  >  https://us-east.manta.joyent.com/pkgsrc/public/reports/upstream-trunk/20210622.1454/modular-xorg-server-1.20.11/build.log
  >  
  >  As such I think libnbcompat is not a feasible approach to
  >  solve this problem and we should back out the patches entirely and
  >  provide the package with a local copy of strnlen until we have a
  >  USE_FEATURES framework that can support better symbol granularity.
 
 I committed the patches in 41501 so modular-xorg-server itself likely
 builds on Solaris now; so it may be worth looking into this one again.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost