Re: CVS commit: pkgsrc

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Module Name:    pkgsrc
> Committed By:   adam
> Date:           Sun Mar 30 06:18:07 UTC 2025
> 
> Log Message:
> sqlite3: updated to 3.49.1

> +# For autosetup use jimsh instead of tclsh, as tcl requires sqlite3.
> +TOOL_DEPENDS+= jimtcl>0:../../lang/jimtcl
> +CONFIGURE_ENV+=        autosetup_tclsh=${PREFIX}/bin/jimsh

Why does this need a new dependency?  Doesn't the new sqlite3 build
process automatically bootstrap its own jimsh0?

Bringing this in had the side effect of breaking the build on Linux
because it installs pkgsrc zlib for jimtcl but doesn't buildlink3 it
for sqlite3, which confused the REQUIRES handling into thinking
sqlite3 needed pkgsrc libz.so which is not provided by any
dependencies.

I have worked around that side effect by forcibly disabling zlib in
sqlite3 for now (we should probably enable it and buildlink3 it but I
wanted to fix the regression first, then discuss the way forward).

> -lib/libsqlite3.la
> +lib/libsqlite3.a
> +lib/libsqlite3.so.0
> +lib/libsqlite3.so.${PKGVERSION}
> +lib/libsqlite3.so

How did you test this change?  I don't think this will work on Darwin.

I think we should have a bulk-test-sqlite3 and/or mandatory review for
changes to such an important package, especially for major build
system changes like this.