Re: CVS commit: pkgsrc

[Greg Troxel <gdt%lexort.com@localhost>]

Taylor R Campbell <riastradh%NetBSD.org@localhost> writes:

>> Module Name:    pkgsrc
>> Committed By:   adam
>> Date:           Sun Mar 30 06:18:07 UTC 2025
>> 
>> Log Message:
>> sqlite3: updated to 3.49.1
>
>> +# For autosetup use jimsh instead of tclsh, as tcl requires sqlite3.
>> +TOOL_DEPENDS+= jimtcl>0:../../lang/jimtcl
>> +CONFIGURE_ENV+=        autosetup_tclsh=${PREFIX}/bin/jimsh
>
> Why does this need a new dependency?  Doesn't the new sqlite3 build
> process automatically bootstrap its own jimsh0?

I would say that sqlite3 is so foundational that we should try very hard
not to have any dependencies that are not really necessary, added only
with discussion.

> How did you test this change?  I don't think this will work on Darwin.
>
> I think we should have a bulk-test-sqlite3 and/or mandatory review for
> changes to such an important package, especially for major build
> system changes like this.

Agreed.  wiz: Please add to restricted list, when updates involve build
system changes, new dependencies, or ABI breaks.