Re: CVS commit: pkgsrc

[Adam <adam%netbsd.org@localhost>]

>>> +# For autosetup use jimsh instead of tclsh, as tcl requires sqlite3.
>>> +TOOL_DEPENDS+= jimtcl>0:../../lang/jimtcl
>>> +CONFIGURE_ENV+=        autosetup_tclsh=${PREFIX}/bin/jimsh
>> 
>> Why does this need a new dependency?  Doesn't the new sqlite3 build
>> process automatically bootstrap its own jimsh0?
> 
> I would say that sqlite3 is so foundational that we should try very hard
> not to have any dependencies that are not really necessary, added only
> with discussion.

jimtcl is required only to build sqlite3. Tcl can't be used as lang/tcl itself depends on sqlite3. There is an internal jimsh included with sqlite3 distribution, but I thought:

1. let's have an external jimsh built once, so it can be used for both sqlite3 and sqlite3-tcl

2. jimtcl is a TOOL dependency, so probably sqlite3 can't be cross-compiled with the internal one, but I might be wrong.

I don't understand the reasoning regarding pulling zlib as a dependency. jimtcl is used as a tool, and not buildlinked, right?


>> How did you test this change?  I don't think this will work on Darwin.
>> 
>> I think we should have a bulk-test-sqlite3 and/or mandatory review for
>> changes to such an important package, especially for major build
>> system changes like this.
> 
> Agreed.  wiz: Please add to restricted list, when updates involve build
> system changes, new dependencies, or ABI breaks.

I always build on NetBSD and Darwin (aka macOS).

Kind regards,
Adam